Skip to content

style: enable LocalVariableName in CheckStyle #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2024
Merged

style: enable LocalVariableName in CheckStyle #5191

merged 6 commits into from
May 28, 2024

Conversation

cpu-pixel
Copy link
Contributor

@cpu-pixel cpu-pixel commented May 28, 2024 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Related to [OTHER] Enable more checks in checkstyle #5119

@cpu-pixel cpu-pixel closed this May 28, 2024
@cpu-pixel cpu-pixel reopened this May 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.12426% with 199 lines in your changes are missing coverage. Please review.

Project coverage is 38.62%. Comparing base (81cb09b) to head (f4a6ee5).

Files Patch % Lines
...c/main/java/com/thealgorithms/others/PageRank.java 0.00% 19 Missing ⚠️
...orithms/datastructures/lists/CursorLinkedList.java 0.00% 16 Missing ⚠️
...programming/ShortestCommonSupersequenceLength.java 0.00% 12 Missing ⚠️
...main/java/com/thealgorithms/maths/MagicSquare.java 0.00% 12 Missing ⚠️
...ithms/datastructures/graphs/BipartiteGrapfDFS.java 0.00% 11 Missing ⚠️
...ain/java/com/thealgorithms/maths/FFTBluestein.java 0.00% 11 Missing ⚠️
...thealgorithms/datastructures/stacks/NodeStack.java 0.00% 10 Missing ⚠️
...ms/datastructures/graphs/DIJSKSTRAS_ALGORITHM.java 0.00% 9 Missing ⚠️
...ain/java/com/thealgorithms/ciphers/HillCipher.java 0.00% 6 Missing ⚠️
...astructures/hashmap/hashing/MainCuckooHashing.java 0.00% 6 Missing ⚠️
... and 24 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5191      +/-   ##
============================================
- Coverage     38.62%   38.62%   -0.01%     
- Complexity     2378     2379       +1     
============================================
  Files           516      516              
  Lines         15385    15385              
  Branches       2957     2957              
============================================
- Hits           5943     5942       -1     
- Misses         9157     9158       +1     
  Partials        285      285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpu-pixel cpu-pixel changed the title Related to [OTHER] Enable more checks in checkstyle #5119 style: enable LocalVariableName in CheckStyle May 28, 2024
vil02
vil02 requested changes May 28, 2024
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very tough pull-requets. Thanks for doing it. I have some small remarks.

@vil02 vil02 mentioned this pull request May 28, 2024
Closed
26 tasks
@vil02 vil02 merged commit 25d711c into TheAlgorithms:master May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpu-pixel @codecov-commenter @vil02